(WIP) add importsNotUsedAsValues:error to tsconfig, fix resulting code errors#1501
Draft
trusktr wants to merge 1 commit intosolidjs:mainfrom
Draft
(WIP) add importsNotUsedAsValues:error to tsconfig, fix resulting code errors#1501trusktr wants to merge 1 commit intosolidjs:mainfrom
trusktr wants to merge 1 commit intosolidjs:mainfrom
Conversation
|
Pull Request Test Coverage Report for Build 4019290439
💛 - Coveralls |
Contributor
Author
|
Interesting, how can all tests have passed. Still need to update code. |
|
I'm seeing this error when trying to import |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Solid leaves type imports behind, causing some systems to try to import non-existing things at runtime.
This relates to the node vs web structure. The app in question
importslume, whichimportssolid-js/html, etc, however does not use these APIs on the backend, only on the client.The workaround for the app is to use
await import('lume')in client-side code, so it is ignored in SvelteKit pre-rendering.Here's a sample error:
How did you test this change?
Not done yet, need to test and update code