make a named export for solid-js/html for autocompletion in IDEs#2267
Open
trusktr wants to merge 1 commit intosolidjs:mainfrom
Open
make a named export for solid-js/html for autocompletion in IDEs#2267trusktr wants to merge 1 commit intosolidjs:mainfrom
trusktr wants to merge 1 commit intosolidjs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 467e872 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 10655705996Details
💛 - Coveralls |
1dc2c36 to
467e872
Compare
2 tasks
Contributor
Author
|
Actually I just tested, and autocompletion will work as long as the app already imports the default This does make it easy to write things like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clearly-named exports appear as autocomplete results in IDEs like VS Code. This allows someone to, for example, write the following JS code with
|representing the cursor location:and IDEs that use TypeScript Language Server (f.e. VS Code) will propose to automatically add
import {html} from 'solid-js/html', converting the code to the following when the user hits the Tab key (default in most IDEs) to accept the auto-completion: