Moving solidus_sample to be development dependency#5591
Open
softr8 wants to merge 1 commit intosolidusio:mainfrom
Open
Moving solidus_sample to be development dependency#5591softr8 wants to merge 1 commit intosolidusio:mainfrom
softr8 wants to merge 1 commit intosolidusio:mainfrom
Conversation
elia
reviewed
Jan 10, 2024
Member
elia
left a comment
There was a problem hiding this comment.
This is a great idea!
Could you please move the dependency to the main Gemfile and also change the core install_generator so that it will add it to the host application Gemfile (with group: :development)?
259d199 to
7358f20
Compare
Solidus Sample gem includes seed data to setup local development in an easy way, it includes catalogs for countries, states, products, taxonomies/taxons and images. This gem itself needs about 10mb of disk space and most of the times it is only needed in local development or one time.
7358f20 to
6eb253e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5591 +/- ##
==========================================
- Coverage 88.66% 88.65% -0.02%
==========================================
Files 683 683
Lines 16293 16296 +3
==========================================
+ Hits 14446 14447 +1
- Misses 1847 1849 +2 ☔ View full report in Codecov by Sentry. |
tvdeyen
requested changes
Nov 15, 2024
Member
tvdeyen
left a comment
There was a problem hiding this comment.
This is a really good idea. Do you mind to update the PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Solidus Sample gem includes seed data to setup local development in an easy way, it includes catalogs for countries, states, products, taxonomies/taxons and images. This gem itself needs about 10mb of disk space and most of the times it is only needed in local development or one time.
Example
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: