Refactor "current_api_user" into instacached helper#6246
Merged
tvdeyen merged 1 commit intosolidusio:mainfrom May 30, 2025
Merged
Refactor "current_api_user" into instacached helper#6246tvdeyen merged 1 commit intosolidusio:mainfrom
tvdeyen merged 1 commit intosolidusio:mainfrom
Conversation
2efcacd to
48fe06d
Compare
tvdeyen
approved these changes
May 29, 2025
jarednorman
approved these changes
May 29, 2025
In the same spirit as the previous commit, which refactored `@current_user_roles` into a helper method, we do the same for the `current_api_user`. Also fixes a spec that previously compared a user object with a string, hoping them not to be identical (they never would be).
48fe06d to
5dad30f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6246 +/- ##
==========================================
- Coverage 88.82% 88.82% -0.01%
==========================================
Files 850 850
Lines 18334 18337 +3
==========================================
+ Hits 16286 16288 +2
- Misses 2048 2049 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the same spirit as #6245 , which refactored
@current_user_rolesinto a helper method, we do the same for thecurrent_api_user.Depends on #6245, extracted from #6240.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: