Shipping category foreign keys#6278
Merged
tvdeyen merged 2 commits intosolidusio:mainfrom Jun 18, 2025
Merged
Conversation
github-actions
bot
added
the
changelog:solidus_core
mamhoff
force-pushed
the
shipping-category-foreign-keys
branch
from
4d5f91a to
8ba4a68
Compare
github-actions
bot
added
the
changelog:solidus_backend
mamhoff
force-pushed
the
shipping-category-foreign-keys
branch
from
8ba4a68 to
45f05d3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6278 +/- ##
==========================================
- Coverage 88.95% 88.95% -0.01%
==========================================
Files 860 860
Lines 18423 18422 -1
==========================================
- Hits 16388 16387 -1
Misses 2035 2035 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mamhoff
force-pushed
the
shipping-category-foreign-keys
branch
from
45f05d3 to
fe085ed
Compare
adammathys
approved these changes
Jun 6, 2025
The `Spree::ShippingMethodCategory` is a join model and needs foreign keys on both ends. The shipping method id on products was mandatory before, so it's safe to remove the `optional: true` on the `belongs_to` declaration and add a foreign key constraint here as well.
mamhoff
force-pushed
the
shipping-category-foreign-keys
branch
from
fe085ed to
4b87bdd
Compare
tvdeyen
approved these changes
Jun 18, 2025
github-project-automation
bot
moved this from In Progress
to Done
in Solidus Public Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds foreign key constraints and validations to tables related to shipping categories, specifically
spree_productsandspree_shipping_method_categories.Extracted from #6240
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: