Add proper checks to exclude code for older ESP-IDF versions#214
Open
netmindz wants to merge 1 commit intosomeweisguy:release/v4.1from
Open
Add proper checks to exclude code for older ESP-IDF versions#214netmindz wants to merge 1 commit intosomeweisguy:release/v4.1from
netmindz wants to merge 1 commit intosomeweisguy:release/v4.1from
Conversation
|
Many thanks Will, works perfectly for me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude thinks this is the correct fix ...
The file already has the proper includes for IDF V5, but the actual implementation in the dmx_uart_init and dmx_uart_deinit functions still uses the old API. The attached file shows the CORRECT version. Let me replace the old implementation with the IDF V5-compatible version from the attachment:
Now let me replace the entire dmx_uart_init and dmx_uart_deinit functions with the proper IDF V5-compatible versions:
The code is the same. The issue is that in IDF V5.2+, the uart_periph_signal structure doesn't have a .module member. Let me check what members it does have and fix it properly: