v2: take only 'bitsMachine' least significant bits from generated machine IDs so it doesn't corrupt the other ID parts#72
Merged
YoshiyukiMineo merged 2 commits intosony:check-compose-argsfrom May 18, 2025
Conversation
…hine IDs so it doesn't corrupt the other ID parts
Member
|
Thank you for notifying me of the bug. |
YoshiyukiMineo
added a commit
that referenced
this pull request
May 18, 2025
* v2: take only 'bitsMachine' least significant bits from generated machine IDs so it doesn't corrupt the other ID parts (#72) Co-authored-by: ok32 <e.starikoff@gmail.com> Co-authored-by: Yoshiyuki Mineo <Yoshiyuki.Mineo@jp.sony.com> * Refactor Sonyflake Compose method to return errors for invalid parameters and update related tests. Consolidate error handling for start time, sequence, and machine ID validations. Remove unused variable in tests for clarity. --------- Co-authored-by: ok32 <artuh.gubanova@gmail.com> Co-authored-by: ok32 <e.starikoff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.