Skip to content

Allow selecting custom fonts#929

Open
Philiquaz wants to merge 1 commit intosoulsmods:masterfrom
Philiquaz:feat/fontSelection
Open

Allow selecting custom fonts#929
Philiquaz wants to merge 1 commit intosoulsmods:masterfrom
Philiquaz:feat/fontSelection

Conversation

@Philiquaz
Copy link
Collaborator

darkmatter is really persuasive and it's a low hanging fruit

@vawser
Copy link
Contributor

vawser commented Jun 29, 2024

Looks good.
Only improvement might be to check the validity of the font in some way, since I tested this feature in Smithbox (same implementation) with Wingdings and it threw an exception, whereas other fonts worked fine.
image

@Philiquaz
Copy link
Collaborator Author

Hmmm... so far as I can guess, ImFontAtlasGetTexDataAsRGBA32 isn't rasterising the font as expected and that's leading us to try create some misformed texture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants