fix: Configures the vars for communication between app and sidecar for otel#102
Open
blainsmith wants to merge 6 commits intosource-cooperative:feat/otelfrom
Open
fix: Configures the vars for communication between app and sidecar for otel#102blainsmith wants to merge 6 commits intosource-cooperative:feat/otelfrom
blainsmith wants to merge 6 commits intosource-cooperative:feat/otelfrom
Conversation
alukach
approved these changes
Jan 15, 2026
Contributor
alukach
left a comment
There was a problem hiding this comment.
Merging to feat/otel so that we can deploy to staging via Github Actions.
| @@ -65,6 +65,7 @@ export class SourceDataProxy extends Construct { | |||
| environment: { | |||
| ...props.environment, | |||
| OTEL_EXPORTER_OTLP_ENDPOINT: "http://localhost:4317", | |||
Contributor
There was a problem hiding this comment.
I'm uncertain if the usage of localhost within the a Fargate cluster works, but let's try and see.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I'm changing
- Explicitly maps port 4317 for the ADOT collector
- Ensures the gRPC endpoint is properly accessible within the task
How I did it
How to test it
After deploying this change, your traces should start flowing to X-Ray. You can verify by checking the ADOT container logs at /ecs/{stack-name}-adot and looking for trace export activity.
PR Checklist
and I have opened issue/PR #XXX to track the change.