Indicate range request support with Accept-Ranges header#104
Open
cmsetzer wants to merge 1 commit intosource-cooperative:mainfrom
Open
Indicate range request support with Accept-Ranges header#104cmsetzer wants to merge 1 commit intosource-cooperative:mainfrom
cmsetzer wants to merge 1 commit intosource-cooperative:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I'm changing
This appends the
Accept-Rangesheader to GET and HEAD responses for objects, indicating support for HTTP range requests. Since some clients look for this header, it should improve use of range requests.Addresses #103.
How I did it
get_objectandhead_objectresponses now includeAccept-Ranges, as well asAccess-Control-Expose-Headersfor CORS safelisting.How to test it
When running the proxy:
Accept-Ranges: bytesandAccess-Control-Expose-Headers: Accept-Rangesshould both be presentPR Checklist
and I have opened issue/PR #XXX to track the change.
Related Issues
[Proposed Feature] Indicate range request support with Accept-Ranges header