Conversation
(x_idl, y_idl) correspond to (y, z) components of the unit vector respectively.
Did not work if any element of x_rad, y_rad, z_rad was zero.
Two new functions added simplyfing the idl to tel coordinate system conversions. method is assumed to be spherical, planar_approximation is eliminated. idl coords could be specified in either spherical or in tangent plane. updated function logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one does bug fix and adds new functions to implement
function “idl_to_tel" with keywords
method=’spherical', input_coordinates='tangent_plane’, output_coordinates=’spherical'
function “tel_to_idl" with keywords
method=’spherical', input_coordinates=’spherical', output_coordinates='tangent_plane’