Changed lab 2 - question 4b testcases to unicode strings.#6
Open
Jabokoe wants to merge 1 commit intospark-mooc:masterfrom
Jabokoe:patch-1
Open
Changed lab 2 - question 4b testcases to unicode strings.#6Jabokoe wants to merge 1 commit intospark-mooc:masterfrom Jabokoe:patch-1
Jabokoe wants to merge 1 commit intospark-mooc:masterfrom
Jabokoe:patch-1
Conversation
The RDD this function will be used on contains unicode strings. This test uses default type strings, causing implementations of removePunctuation that use string.translate() to pass this test. However string.translate() does not behave well for unicode strings, which cause cryptic errors later down the line (4c). Aditionally positive test results for 4b wil confuse students debugging errors at 4c. Changing the testcases to unicode strings better guides students towards using the regular expressions (re) module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RDD the student specified 'removePunctuation()' function will be used on contains unicode strings.
This test (4b) used default type strings, causing implementations of removePunctuation that use '.translate()' to pass this test.
However '.translate()' does not behave well for unicode strings, which cause cryptic errors later down the line (4c).
Aditionally positive test results for 4b wil confuse students debugging errors at 4c.
Changing the testcases to unicode strings better guides students towards using the regular expressions (re) module for answering question 4b.