Open
Conversation
As far as I can tell the otherwise is otherwise 100% ESP32 Compatible
mehtajainam
approved these changes
Mar 25, 2019
mehtajainam
left a comment
mehtajainam
left a comment
There was a problem hiding this comment.
Just tested this and it works perfectly. Thanks!
Board: Adafruit Feather HUZZAH32
MPU-9250 breakout from Sparkfun
Arduino IDE 1.8.8
Windows 10
Added definition of min() for ESP8266
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell the otherwise is otherwise 100% ESP32 Compatible.
A definition for the min function is all that prevents the library from compiling with ESP32.
I tested the DMP Pedometer sketch just fine using the Heltec Lora ESP32 Modules.