feat: Implement Document#parent, which always returns nil#3481
Open
flavorjones wants to merge 1 commit intomainfrom
Open
feat: Implement Document#parent, which always returns nil#3481flavorjones wants to merge 1 commit intomainfrom
flavorjones wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
We've
undefed theparentmethod inDocumentsince ffbfc73 in 2009. There's no good reason to do so, and restoring the method so it returnsnilmakes the Document object quack more like the Node that it is.Closes #3466
Have you included adequate test coverage?
Yes.
Does this change affect the behavior of either the C or the Java implementations?
N/A