Skip to content

Conversation

@bruAristimunha
Copy link
Contributor

Summary

  • Fix LEM and Log-Cholesky parallel transport to be non-trivial in the ambient SPD tangent space, replacing the incorrect identity transport. LEM now uses Fréchet derivatives of matrix log/exp (Thanwerdas & Pennec 2023), and Log-Cholesky uses Cholesky pullback/pushforward (Lin 2019, Proposition 7).
  • Add frechet.py module with frechet_derivative_log and frechet_derivative_exp via the Daleckii-Krein theorem, using the existing Loewner matrix pattern.
  • Fix linkcode_resolve in Sphinx docs to use inspect.getsourcefile with line numbers instead of the broken src/ prefix approach.
  • Expand test coverage with self-transport, roundtrip, linearity, inner product preservation, gradient flow, non-identity assertion, and parametrized batch tests for all three transport methods.

Test plan

  • All 74 tests in test_transport.py pass
  • Verify Sphinx docs build with correct source links
  • Run the plot_parallel_transport.py example to confirm updated output

…port

Fix thanwerdas2023n -> thanwerdas2023 citation key in LEM transport
docstring, add missing trailing newline in references.bib, and replace
standalone AIRM batch test with a parametrized test covering all three
transport methods (AIRM, LEM, Log-Cholesky).
Rename abbreviated variable to fix codespell check, reorder imports
alphabetically, and apply formatting fixes across documentation and
workflow files.
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

📚 Documentation Preview

📦 Download Documentation Artifact

Download the documentation-html artifact from the workflow run to view the docs locally.

💡 To enable live previews, add a SURGE_TOKEN secret to this repository. See surge.sh for setup instructions.

Replace RST grid table with list-table directive to avoid
column alignment issues caused by multi-byte Unicode characters
(³, ², ·, é) that triggered Sphinx "Malformed table" errors on CI.
@bruAristimunha
Copy link
Contributor Author

many thanks for pointing out the issues @qbarthelemy

@bruAristimunha bruAristimunha merged commit 28428ec into main Feb 9, 2026
11 checks passed
@bruAristimunha bruAristimunha deleted the fix/parallel-transport-and-source-links branch February 10, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant