Fix BW geodesic and add pyriemann comparison tests#2
Merged
bruAristimunha merged 2 commits intomainfrom Feb 10, 2026
Merged
Conversation
The BW geodesic cross-term was incorrectly using M + M^T (where M is
symmetric, so this equals 2M) instead of (AB)^{1/2} + (BA)^{1/2}.
The correct cross-term is A^{1/2} M A^{-1/2} + A^{-1/2} M A^{1/2}.
Add 82 comparison tests validating spd_learn against pyriemann for
matrix ops, distances, geodesics, means, and log/exp maps.
Add pyriemann to test dependencies.
Reformat test_pyriemann_comparison.py with ruff to fix pre-commit check. Add continue-on-error to the docs workflow PR comment step so transient GitHub API 429 errors don't fail the build.
📚 Documentation Preview📦 Download Documentation Artifact
💡 To enable live previews, add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
M + M^T(=2M) instead of(AB)^{1/2} + (BA)^{1/2}(=A^{1/2} M A^{-1/2} + A^{-1/2} M A^{1/2})pyriemannto test dependenciesTest plan
pytest tests/test_pyriemann_comparison.py— 82 passedpytest tests/test_transport.py— 74 passed (no regressions)ruff checkclean