Merged
Conversation
Created the Dockerfile for Java.
GerardChabaBristol
added
Testing
Closed
Contributor
|
Why is the same issue already addressed in PR #117 ? Are you sure we don't need to separate the issue into smaller ones? |
vladislav-k1
approved these changes
Jan 17, 2025
Contributor
vladislav-k1
left a comment
vladislav-k1
left a comment
There was a problem hiding this comment.
The code works and looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s):
#104
Type of change: (choose required ones)
Description:
Created the Dockerfile to implement CD.
Additional context:
The code might need some adjusting depending on if the "deploy-ghcr.yaml" Github action is able to use it correctly.
Testing instructions:
The Dockerfile has been tested locally and works. If the "deploy-ghcr.yaml" Github action can successfully use this Dockerfile, then this means the testing is successful.