Merged
Conversation
Created a Github action that deploys an image to GHCR.
Updated deploy-ghcr.yml to work with the Dockerfile.
GerardChabaBristol
added
Testing
Siyuan106
approved these changes
Jan 16, 2025
Contributor
|
looks good！ |
vladislav-k1
approved these changes
Jan 17, 2025
Contributor
vladislav-k1
left a comment
vladislav-k1
left a comment
There was a problem hiding this comment.
Looks good, pay attention to line 31 in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s):
#120
Type of change: (choose required ones)
Description:
Created a Github Action that builds and deploys the Docker image to our Github Container Repository for CD.
Additional context:
The code contains a GitHub secret which was added by our mentor. If the names don't match, the code might need some adjustments.
Testing instructions:
The Action runs when something is pushed to dev. We need to push something to dev and check our GHCR to see if an image was successfully made.