Conversation
…not - refuse to start the Spring Boot server and ask user to add the file and try again.
yi23484
changed the title
…oot, issue is now fixed and project should build correctly
vladislav-k1
requested changes
Jan 24, 2025
Contributor
vladislav-k1
left a comment
vladislav-k1
left a comment
There was a problem hiding this comment.
If keystore.p12 file isn't present, the backend fails to start up. We should implement some sort of protection against this. Maybe even an option to start up without HTTPS (eg. for execution on localhost). Logs:
2025-01-24T12:19:46.375Z INFO 476552 --- [AILearningTool] [ main] c.U.A.AiLearningToolApplication : No active profile set, falling back to 1 default profile: "default"
2025-01-24T12:19:47.445Z WARN 476552 --- [AILearningTool] [ main] ConfigServletWebServerApplicationContext : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.context.ApplicationContextException: Unable to start web server
2025-01-24T12:19:47.453Z INFO 476552 --- [AILearningTool] [ main] .s.b.a.l.ConditionEvaluationReportLogger :
Error starting ApplicationContext. To display the condition evaluation report re-run your application with 'debug' enabled.
2025-01-24T12:19:47.467Z ERROR 476552 --- [AILearningTool] [ main] o.s.boot.SpringApplication : Application run failed```
…tps if keystore.p12 does not exist in src/main/resources/keystore.p12
…ncorrectly looked for a different keystore.p12 which was causing backend to launch without SSL, even when keystore.p12 is present
Contributor
Author
|
I changed it so that the backend launches with SSL disabled if launched without keystore.p12. |
…ificate-integration
vladislav-k1
dismissed stale reviews from GerardChabaBristol and themself
via
0ac0eff
yi23484
deleted the
optimisation/issue-124/simplify-security-certificate-integration
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s):
#124
Type of change: (choose required ones)
Description:
check if keystore.p12 file exists in /src/main/resources/ . If not - refuse to start the Spring Boot server and ask user to add the file and try again.