chore: Reorganise directories, refactor Github runner and Dockerfile#155
Merged
vladislav-k1 merged 2 commits intodevfrom Jan 31, 2025
Merged
Conversation
vladislav-k1
added
the
Github
vladislav-k1
requested review from
GerardChabaBristol,
Liuwf4319 and
Siyuan106
RainBOY-ZZX
previously approved these changes
Jan 31, 2025
Siyuan106
previously approved these changes
Jan 31, 2025
Contributor
Siyuan106
left a comment
Siyuan106
left a comment
There was a problem hiding this comment.
The file structure looks good now.
GerardChabaBristol
requested changes
Jan 31, 2025
Collaborator
GerardChabaBristol
left a comment
GerardChabaBristol
left a comment
There was a problem hiding this comment.
The 'target' directory is in the root of the repo, so the change to Dockerfile will most likely break it. Kindly revert the Dockerfile to the way it was originally.
vladislav-k1
dismissed stale reviews from Siyuan106 and RainBOY-ZZX
via
2996eee
GerardChabaBristol
approved these changes
Jan 31, 2025
Collaborator
GerardChabaBristol
left a comment
GerardChabaBristol
left a comment
There was a problem hiding this comment.
Great, looks good now.
RainBOY-ZZX
approved these changes
Jan 31, 2025
vladislav-k1
deleted the
hotfix/issue-154/repo-structure-reorganisation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s):
#154
Type of change: (choose required ones)
Description:
Repository file and directory structure had to be improved, separating front end and back end code better.
Additional context:
Everything seems like it works fine
Testing instructions:
Github runner should work as expected.