Conversation
GerardChabaBristol
added
Extra functionality
Closed
3 tasks
GerardChabaBristol
requested review from
Liuwf4319
and removed request for
Siyuan106
vladislav-k1
approved these changes
Mar 13, 2025
Contributor
vladislav-k1
left a comment
vladislav-k1
left a comment
There was a problem hiding this comment.
The code looks good. Works on my machine.
yi23484
approved these changes
Mar 14, 2025
Contributor
yi23484
left a comment
yi23484
left a comment
There was a problem hiding this comment.
Web app works great. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s):
#215
Type of change:
Description:
Made our web app a Progressive Web App (PWA). Users can now download our web app to their desktop on any browser.
Additional context:
I thought of making a custom pop-up to download the PWA, but I don't think it's necessary as it appears automatically on most browsers. Let me know what you think.
Testing instructions:
Run our web app on this branch and download it to your desktop (screenshot on where to find the pop-up below). Try it out to see if it works correctly.