Feature/issue 203/url global variable#221
Merged
vladislav-k1 merged 7 commits intodevfrom Mar 21, 2025
Merged
Conversation
SSL configuration is now a part of CD (implemented with Docker and GitHub runner).
…e-uob/2024-AILearningTool into feature/issue-203/url-global-variable
1 task
GerardChabaBristol
approved these changes
Mar 18, 2025
Collaborator
GerardChabaBristol
left a comment
There was a problem hiding this comment.
The local execution works as intended. Unfortnately, I think the only way to test the CD would be to push to dev, but the changes you made to deploy-ghcr.yml make sense so I believe it would work.
yi23484
approved these changes
Mar 19, 2025
Contributor
yi23484
left a comment
There was a problem hiding this comment.
Local execution works. Pushing to dev to test CD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s):
#203
Type of change:
Description:
frontend/src/assets/globalConstants.jsand is referenced across entire frontend code instead of hardcoded strings.keystore.p12file for deployment.startServer.shhas been replaced withlocalExecute.shto assemble frontend and execute the backend locally.Additional context:
Pay extra attention to the CD runner.
Testing instructions:
For local execution:
localExecute.shscript.For CD process validation:
-p 443:443 ghcr.io/spe-uob/2024-ailearningtool:latest -v keystore.p12:/keystore.p12