Skip to content

Comments

Feature/issue 220/chat export button#237

Merged
Siyuan106 merged 9 commits intodevfrom
feature/issue-220/chat-export-button
Mar 31, 2025
Merged

Feature/issue 220/chat export button#237
Siyuan106 merged 9 commits intodevfrom
feature/issue-220/chat-export-button

Conversation

@Liuwf4319
Copy link
Contributor

@Liuwf4319 Liuwf4319 commented Mar 26, 2025

Issue(s):

#220

Type of change: (choose required ones)

  • New feature

Description:

Add download botten for download chat history.

Testing instructions:

Press the Download button to view the downloaded file

@Liuwf4319 Liuwf4319 added Frontend Issue relates to frontend code. Final Issue relates to Final release. labels Mar 26, 2025
@Liuwf4319 Liuwf4319 added this to the Final Release milestone Mar 26, 2025
vladislav-k1
vladislav-k1 previously approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@vladislav-k1 vladislav-k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as discussed

RainBOY-ZZX
RainBOY-ZZX previously approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@RainBOY-ZZX RainBOY-ZZX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GerardChabaBristol
GerardChabaBristol requested changes Mar 28, 2025
View reviewed changes
Copy link
Collaborator

@GerardChabaBristol GerardChabaBristol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a random button on the right of the chat, it would be better to add a "..." button next to each chat, and add a "Export chat" button in there.

@Siyuan106
Implement three dots option button, move export chat in that option menu
c11de3a 
Add a three-dot settings menu to each chat record in the HistorySidebar. In the menu, include an option called Export that allows saving the chat as a .txt file to the local device.
@Siyuan106 Siyuan106 dismissed stale reviews from RainBOY-ZZX and vladislav-k1 via c11de3a March 30, 2025 19:37
RainBOY-ZZX
RainBOY-ZZX approved these changes Mar 30, 2025
View reviewed changes
Copy link
Contributor

@RainBOY-ZZX RainBOY-ZZX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, the function is working

@Siyuan106
Copy link
Contributor

Siyuan106 commented Mar 31, 2025

Instead of a random button on the right of the chat, it would be better to add a "..." button next to each chat, and add a "Export chat" button in there.
Done!👌

@Siyuan106 Siyuan106 closed this Mar 31, 2025
@Siyuan106 Siyuan106 reopened this Mar 31, 2025
@RainBOY-ZZX RainBOY-ZZX self-requested a review March 31, 2025 12:06
RainBOY-ZZX
RainBOY-ZZX previously approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@RainBOY-ZZX RainBOY-ZZX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GerardChabaBristol
GerardChabaBristol requested changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@GerardChabaBristol GerardChabaBristol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the option "I need help with choosing a course", the "..." button is a bit too close to the text. Try moving it a bit more to the right.

image

@Siyuan106
Copy link
Contributor

Siyuan106 commented Mar 31, 2025

For the option "I need help with choosing a course", the "..." button is a bit too close to the text. Try moving it a bit more to the right.

image

Right now it is more right, wont covered by the chat title.

@Siyuan106 Siyuan106 requested a review from RainBOY-ZZX March 31, 2025 12:30
GerardChabaBristol
GerardChabaBristol approved these changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@GerardChabaBristol GerardChabaBristol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Button looks good now and works as intended. LGTM.

RainBOY-ZZX
RainBOY-ZZX approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@RainBOY-ZZX RainBOY-ZZX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@Siyuan106 Siyuan106 merged commit e0d7ae3 into dev Mar 31, 2025
2 checks passed
@Siyuan106 Siyuan106 deleted the feature/issue-220/chat-export-button branch March 31, 2025 13:17
@GerardChabaBristol GerardChabaBristol mentioned this pull request Apr 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GerardChabaBristol GerardChabaBristol GerardChabaBristol approved these changes

@RainBOY-ZZX RainBOY-ZZX RainBOY-ZZX approved these changes

@yi23484 yi23484 Awaiting requested review from yi23484

@vladislav-k1 vladislav-k1 Awaiting requested review from vladislav-k1

Assignees

@Liuwf4319 Liuwf4319

@Siyuan106 Siyuan106

Labels

Final Issue relates to Final release. Frontend Issue relates to frontend code.

Projects

None yet

Milestone

Final Release

Development

Successfully merging this pull request may close these issues.

5 participants

@Liuwf4319 @Siyuan106 @GerardChabaBristol @vladislav-k1 @RainBOY-ZZX