Skip to content

Comments

feature/issue-209/update-readme#243

Merged
GerardChabaBristol merged 9 commits intodevfrom
feature/issue-209/update-readme
Apr 2, 2025
Merged

feature/issue-209/update-readme#243
GerardChabaBristol merged 9 commits intodevfrom
feature/issue-209/update-readme

Conversation

@GerardChabaBristol
Copy link
Collaborator

Issue(s):

#209

Type of change:

  • Refactor/Optimization
  • Bugfix

Description:

Updated the README to reflect the current state of our project. Fixed the login bug relating to CD.

Additional context:

  1. Take a look specifically at:
  • Project Structure
  • Tech Stack
  • User Instructions
  • Developer Instructions
  1. @vladislav-k1 has made a bugfix for our CD runner: when registering an account, it was making register requests using HTTP (which is why we couldn't register or login). Take a look at this too.

Testing instructions:

  1. Review the information in the README.
  2. After merging the PR, we can test if the register and login is working.

@GerardChabaBristol GerardChabaBristol added documentation Improvements or additions to documentation Github Issue relates to Github functionality (eg. runners). Deployment Issue relates to deploying our solution. labels Apr 2, 2025
@GerardChabaBristol GerardChabaBristol added this to the Final Release milestone Apr 2, 2025
@GerardChabaBristol GerardChabaBristol linked an issue Apr 2, 2025 that may be closed by this pull request
Copy link
Contributor

@Siyuan106 Siyuan106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@vladislav-k1 vladislav-k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README makes sense and looks good.

@GerardChabaBristol GerardChabaBristol merged commit 0656ade into dev Apr 2, 2025
1 check passed
@GerardChabaBristol GerardChabaBristol deleted the feature/issue-209/update-readme branch April 2, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Deployment Issue relates to deploying our solution. documentation Improvements or additions to documentation Github Issue relates to Github functionality (eg. runners).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Custom Issue]: Update README

3 participants