Open
Conversation
sekelle
approved these changes
May 18, 2022
Collaborator
sekelle
left a comment
sekelle
left a comment
There was a problem hiding this comment.
Looks good to me, I'll see about implementing the two version depending on whether gravity is active or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds artificial conductivity to the momentum equation.
The new function is implemented in kernels.hpp. There, you'll find a few lines commented that should be active when there is gravity and the other way around when there is not. I leave it in this way for you to think of a proper way to implement this within a template, instead of using an if-condition or a pre-compiler directive.