fix: use 770 permissions instead of 700, fixes multi user installs #3356

[zjeffer]

Something is still creating backups in ~/.local/state/spicetify/ with 700 permissions, need to investigate further..

[rxri]

did you test it and is it ready for review or...?

[zjeffer]

It doesn't fully work, I need to investigate why ~/.local/state/spicetify is still being created with 700 permissions. I haven't had time yet but might soon.

[rxri]

It doesn't fully work, I need to investigate why ~/.local/state/spicetify is still being created with 700 permissions.

you sure? because you changed CheckExistAndCreate to use 0770 which is used in GetStateFolder function to create a dir if it doesn't exist

[zjeffer]

Just tested it again with a clean slate, by:

• Removing /opt/spotify and /opt/spicetify-cli
• Uninstalling spotify and spicetify-cli using my package manager
• Reinstalling spotify, chmodding /opt/spotify and /opt/spotify/Apps with a+rw like it says in the wiki
• Rebuilding spicetify-cli from my branch with go build -o spicetify

Running ./spicetify backup from the repo creates a ~/.local/state/spicetify/ folder with 700 permissions. Deleting the folder and trying it again now results in a folder with 750 permissions. Not sure what happened the first time, maybe I saw it wrong. Tried it again a couple of times from a clean slate and it now keeps creating the folder with 750 permissions.

Now calling ./spicetify restore makes /opt/spotify/Apps have the same 750 permissions, because it copies the state folder of course.

[rxri]

why does it create them with 750 tho instead of 770

[zjeffer]

Yeah that's what I'm confused about 😆

[PikachuGabe]

from what I can find, it is caused by https://stackoverflow.com/a/29895320 .