Skip to content
This repository was archived by the owner on Jun 23, 2025. It is now read-only.

Add games rating#52

Open
easysugar wants to merge 6 commits intospilth:mainfrom
easysugar:add-popularity
Open

Add games rating#52
easysugar wants to merge 6 commits intospilth:mainfrom
easysugar:add-popularity

Conversation

@easysugar
Copy link
Collaborator

I didn't find official ratings for the games, so I've added unofficial ratings.
Example:
image

@spilth
Copy link
Owner

spilth commented May 21, 2022

Where do these unofficial ratings come from?

@easysugar
Copy link
Collaborator Author

easysugar commented May 21, 2022

@spilth Almost the first link in the google https://whatnerd.com/every-jackbox-party-pack-ranked/. But it's possible to change ratings to something else.

@spilth
Copy link
Owner

spilth commented May 21, 2022

@easysugar I definitely appreciate the PRs you've been making. I think it would be good to start making Issues for functionality first so they can be discussed before folks start spending time on development.

For example, I don't know how valuable reversing the sort order is. I feel like default to alphabetical for names/packs and best to worst for ratings would be what folks want to see. That would mean a less complicated UX and less complicated code.

@easysugar
Copy link
Collaborator Author

Agree. But I think that ordering is a must for any sorting. So it should contain the reversing order to be logically completed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants