feat: individual support for manual checks and exceptions#84
Open
truptilangalia-crest wants to merge 37 commits intomainfrom
Open
feat: individual support for manual checks and exceptions#84truptilangalia-crest wants to merge 37 commits intomainfrom
truptilangalia-crest wants to merge 37 commits intomainfrom
Conversation
Bumps [splunk-appinspect](https://splunk.com) from 2.14.1 to 2.30.0. --- updated-dependencies: - dependency-name: splunk-appinspect dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
truptilangalia-crest
requested review from
a team,
harshilgajera-crest,
kkania-splunk,
nariyanibhargav,
rajkarkar-crest,
siddharth-khatsuriya and
uoboda-splunk
Contributor
|
Please fix |
uoboda-splunk
suggested changes
Jan 3, 2023
entrypoint.sh
Outdated
| fi | ||
|
|
||
| exit "$exit_code" | ||
| exit "$(($exit_code_failure_check || $exit_code_manual_check))" No newline at end of file |
Contributor
There was a problem hiding this comment.
newline needed - please fix pre-commit and CI
action.yml
Outdated
| description: "Path to file which contains list of manual checks" | ||
| required: false | ||
| default: ".app-vetting.yaml" | ||
| default: ".appinspect.manualcheck" |
Contributor
There was a problem hiding this comment.
what do you think about keeping .yaml extension in the file name? it's more clear what kind of data is inside
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following changes have been done as part of this PR