GH-3170: Change default requiredAcks to all#3171
Open
pch8388 wants to merge 1 commit intospring-cloud:mainfrom
Open
GH-3170: Change default requiredAcks to all#3171pch8388 wants to merge 1 commit intospring-cloud:mainfrom
pch8388 wants to merge 1 commit intospring-cloud:mainfrom
Conversation
Signed-off-by: Seungcheol Kwon (권승철) <seungcheol.kwon@42dot.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the default value of
spring.cloud.stream.kafka.binder.requiredAcksfrom
1toall.Rationale:
acks=allacks=allandenable.idempotence=truerequiredAcks=1may introduce a conflicting configuration and disable idempotence-by-default behavior.Users can keep the legacy behavior by explicitly setting:
spring.cloud.stream.kafka.binder.requiredAcks=1Closes #3170