GH-5255: Fix streaming to return tokens incrementally in SemanticCach…#5391
Merged
markpollack merged 1 commit intospring-projects:mainfrom Feb 4, 2026
Merged
GH-5255: Fix streaming to return tokens incrementally in SemanticCach…#5391markpollack merged 1 commit intospring-projects:mainfrom
markpollack merged 1 commit intospring-projects:mainfrom
Conversation
…in SemanticCacheAdvisor Fixes: spring-projects#5255 The adviseStream() method was using collectList().flatMapMany() which collected all response chunks before returning them to the user, defeating the purpose of streaming. Replace with ChatClientMessageAggregator which: - Returns tokens to the user immediately as they arrive - Aggregates the response in the background - Caches asynchronously when the stream completes Add testStreamingWithAdvisor() integration test that verifies: - Cache miss returns multiple chunks (true streaming) - Cache hit returns single chunk (Flux.just) - Cached content matches returned content Signed-off-by: Soby Chacko <soby.chacko@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eAdvisor
Fixes: #5255
The adviseStream() method was using collectList().flatMapMany() which collected all response chunks before returning them to the user, defeating the purpose of streaming.
Replace with ChatClientMessageAggregator which:
Add testStreamingWithAdvisor() integration test that verifies: