External Config Doc Update #49054
Open
External Config Doc Update #49054
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
Thanks for the PR, but the line above your change has already that exact comment:
|
snicoll
added
status: declined
Member
|
@wilkinsona made me aware that I read the wrong line, sorry about that. |
Member
|
@linkian209 we need you to sign-off your commit as the DCO check fails at the moment. Can you please do that? |
snicoll
added
status: waiting-for-feedback
This patch makes a small change to the documentation for External Configuration regarding how @value behaves with camelCase variables and environment variables. Signed-off-by: Ian Drake <linkian209@gmail.com>
Author
Sorry about that! Done. |
spring-projects-issues
added
status: feedback-provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes a small change to the documentation for External Configuration regarding how
@Valuebehaves with camelCase variables and environment variables.I created a demo application that illustrates that variables that are defined using camelCase and injected using
@Valuenot in the canonical form will pickup values from environment variables.