Jackson uses platform line endings.#1363
Open
arthur-noseda wants to merge 1 commit intospring-projects:mainfrom
Open
Jackson uses platform line endings.#1363arthur-noseda wants to merge 1 commit intospring-projects:mainfrom
arthur-noseda wants to merge 1 commit intospring-projects:mainfrom
Conversation
Contributor
|
We HEAVILY test against Jackson. How is the ONLY place this manifests? |
It looks like this is the only test that explicitly declares a JSON string containing line separators. If formatting is important for that assertion then it could use AssertJ's conventional |
odrotbohm
force-pushed
the
main
branch
3 times, most recently
from
2e02d7a to
856b6b9
Compare
odrotbohm
force-pushed
the
main
branch
4 times, most recently
from
5828e78 to
e643c37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building the project on Windows, I encountered an issue with one of Jackson2HalFormsIntegrationTest's methods. It seems Jackson is using the underlying platform's line ending when serializing. The expected is not met on Windows (nor should it on Mac).