Property Resolving in @RequestMapping for Spring Boot#1375
Closed
lyca wants to merge 2 commits intospring-projects:masterfrom
Closed
Property Resolving in @RequestMapping for Spring Boot#1375lyca wants to merge 2 commits intospring-projects:masterfrom
lyca wants to merge 2 commits intospring-projects:masterfrom
Conversation
- should work in all Spring Boot web applications - the EnvironmentConfiguration is a bit too much - EnvironmentContextFilter should be added to some of the other configuration classes
- added ThreadLocal clean up to test
lyca
changed the title
|
Any chance of merging this PR for a future release, as it would fix a regression when using Spring Boot ? (please see referenced issue) |
Contributor
Author
|
Created an easier solution in #1411 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I provided the solution for #361 I had a special use case that got solved. I thought, the solution would help also in Spring Boot, but I was wrong -> https://stackoverflow.com/questions/22167912/contextloader-getcurrentwebapplicationcontext-always-returns-null
So I worked on another solution for the problem and open this PR to discuss this one.