Open
Conversation
…ug when decreasing)
…lor brightness from UI
EmberLightVFX
force-pushed
the
AMS-with-rotary-selection
branch
from
4962f8e to
2d40c85
Compare
spuder
reviewed
Jun 18, 2025
spuder
requested changes
Jun 18, 2025
Owner
There was a problem hiding this comment.
The common-manual-ams.yaml appears to be nearly identical to the common.yaml
Could we consolidate these changes into the common.yaml?
If a setting needs to be changed we could split it out into a new file (probably openspool-ams.yaml)
Contributor
Author
There was a problem hiding this comment.
Absolutley! I didn't want to break anything thus I made a copy of it.
My idea would be to split as much as possible so inside your esp-device-yaml you would add the packages you want for your setup (ams, no ams, rotary encoder, external led etc) and that's that. I'll make a new PR for the splitting to see what you think about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Bambulab AMS support.
The user can ether use a rotary encoder to switch the slot or directly in the web ui.
This PR uses this the
Update to esphome 2025.6.0PR as a base #62 and would also close #21The pin-layout of esp32-s3-super-mini-manual-ams.yaml is the layout that allows the user to directly solder the ESP32 onto the PN532.
The rotary encoder uses the pins 6 and 7 on the other side of the esp32 but can also be disabled by comment out its import.
I also added a LED slider to set the brightness of the led strip. The slider that is attached to External LED only sets the brightness but when setting the color of the leds using
- light.addressable_set:the led will ignore it and instead usecolor brightness. The added slider sets both the brightness and the color brightness so on restart the leds will always show the expected brightness.This should maybe be an external PR but it ended up being a part of this one, if it's ok.