Skip to content

Comments

PR: Several fixes for the conda backend and the test suite#30

Merged
ccordoba12 merged 4 commits intospyder-ide:mainfrom
ccordoba12:fix-conda-interface
Feb 12, 2025
Merged

PR: Several fixes for the conda backend and the test suite#30
ccordoba12 merged 4 commits intospyder-ide:mainfrom
ccordoba12:fix-conda-interface

Conversation

@ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Feb 9, 2025

  • Use -y to accept changes when using conda to import an env.
  • Log errors that result from running a command with subprocess.
  • Remove code that it's not needed with conda 24.1.0+ and add that as our minimal supported version.
  • Add packaging as a new dependency to be able to compare package versions, and flaky as a new test dependency.

Before we were using --force, which was deprecated in Conda 24.3
Also, add `packaging` as a new dependency to be able to compare package
versions.
@ccordoba12 ccordoba12 added the bug Something isn't working label Feb 9, 2025
@ccordoba12 ccordoba12 added this to the v0.2.0 milestone Feb 9, 2025
@ccordoba12 ccordoba12 self-assigned this Feb 9, 2025
@ccordoba12 ccordoba12 force-pushed the fix-conda-interface branch 2 times, most recently from ed36a29 to 2d9e15a Compare February 9, 2025 19:41
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 62.06897% with 11 lines in your changes missing coverage. Please review.

Project coverage is 83.10%. Comparing base (2f8b69a) to head (7647dd6).

Files with missing lines Patch % Lines
envs_manager/backends/conda_like_interface.py 40.00% 6 Missing and 3 partials ⚠️
envs_manager/tests/test_manager.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   83.61%   83.10%   -0.51%     
==========================================
  Files           7        7              
  Lines         647      663      +16     
  Branches      105       81      -24     
==========================================
+ Hits          541      551      +10     
- Misses         67       72       +5     
- Partials       39       40       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ccordoba12 ccordoba12 force-pushed the fix-conda-interface branch 8 times, most recently from 41aedcf to f761d93 Compare February 9, 2025 21:43
@ccordoba12 ccordoba12 changed the title PR: Several fixes for the conda backend PR: Several fixes for the conda backend and the test suite Feb 9, 2025
@ccordoba12 ccordoba12 force-pushed the fix-conda-interface branch 12 times, most recently from bb06fa9 to 224e7aa Compare February 12, 2025 16:51
@ccordoba12 ccordoba12 merged commit 1ab367e into spyder-ide:main Feb 12, 2025
13 checks passed
@ccordoba12 ccordoba12 deleted the fix-conda-interface branch February 12, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants