PR: Adapt code to make it work for remote development#32
Merged
ccordoba12 merged 10 commits intospyder-ide:mainfrom Jun 2, 2025
Merged
PR: Adapt code to make it work for remote development#32ccordoba12 merged 10 commits intospyder-ide:mainfrom
ccordoba12 merged 10 commits intospyder-ide:mainfrom
Conversation
ccordoba12
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
- Coverage 83.13% 80.73% -2.40%
==========================================
Files 7 8 +1
Lines 664 758 +94
Branches 83 87 +4
==========================================
+ Hits 552 612 +60
- Misses 72 107 +35
+ Partials 40 39 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ccordoba12
force-pushed
the
refactor-for-remote-development
branch
from
061d70a to
301ef43
Compare
ccordoba12
changed the title
ccordoba12
force-pushed
the
refactor-for-remote-development
branch
from
301ef43 to
9553c7d
Compare
ccordoba12
force-pushed
the
refactor-for-remote-development
branch
3 times, most recently
from
124b28a to
5755e8e
Compare
- That will make possible to serialize those results to json and send them to frontend in case backend and frontend live in different machines. - Also, return the stdout/stderr of the subprocesses we use instead of the object itself. This is also necessary for remote development. - Fix catching the right exception in many places (we were assuming that all exceptions have a stderr attr when only CalledProcessError does). - Don't return the exit code on errors because it doesn't give additional info to users.
This will improve code completions and make it easier to add other backends in the future.
That could lead to errors so it's better to avoid it.
ccordoba12
force-pushed
the
refactor-for-remote-development
branch
5 times, most recently
from
ce63de0 to
0d8f87b
Compare
ccordoba12
force-pushed
the
refactor-for-remote-development
branch
from
0d8f87b to
5eb8f61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BackendActionResultdict andManageraManagerActionResultdict for their actions. This will make possible to serialize those results to json and send them to the frontend in case backend and frontend live in different machines.Managerand backends.backendsone.