Skip to content

PR: Fixes and improvements for final integration with Spyder #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ccordoba12 wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

PR: Fixes and improvements for final integration with Spyder #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2efb358
Add create_kernelspec method to the manager
ccordoba12 Jul 9, 2025
47231b3
Fix importing env from bytes in Pixi backend
ccordoba12 Jul 9, 2025
0332ea9
Return envs list for Pixi backend in the format expected by Spyder
ccordoba12 Oct 8, 2025
55c1e94
Add utility function to get the Python executable from Pixi env path
ccordoba12 Oct 8, 2025
a195102
Add python_version as a separate option when creating environments
ccordoba12 Oct 8, 2025
aaacef7
Add utility function to get Python version from Pixi toml file
ccordoba12 Oct 8, 2025
a23f893
Remove env path if creating env fails for the Pixi backend
ccordoba12 Oct 8, 2025
53e1b66
Replace calls to logger.error for logger.info in backends
ccordoba12 Oct 8, 2025
fcc6fb4
Fix setting Python version for remote envs
ccordoba12 Oct 21, 2025
859a31a
Use shutil.rmtree to delete environments in the Pixi backend
ccordoba12 Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/windows-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
tests:
name: Test Python ${{ matrix.python-version }}
runs-on: windows-latest
timeout-minutes: 25
timeout-minutes: 35
env:
PYTHON_VERSION: ${{ matrix.python-version }}
strategy:
Expand Down
4 changes: 4 additions & 0 deletions envs_manager/backends/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,16 @@ def __init__(
environment_path: str,
envs_directory: str,
bin_directory: str,
python_version: str | None,
):
self.environment_path = environment_path
self.envs_directory = envs_directory
self.bin_directory = bin_directory
self.python_version = python_version

self.external_executable = None
self.executable_variant = None

assert self.validate(), f"{self.ID} backend unavailable!"

@property
Expand Down
28 changes: 18 additions & 10 deletions envs_manager/backends/conda_like_interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,10 @@
class CondaLikeInterface(BackendInstance):
ID = "conda-like"

def __init__(self, environment_path, envs_directory, bin_directory):
super().__init__(environment_path, envs_directory, bin_directory)
def __init__(self, environment_path, envs_directory, bin_directory, python_version):
super().__init__(
environment_path, envs_directory, bin_directory, python_version
)

# This is needed for Micromamba
os.environ["MAMBA_ROOT_PREFIX"] = str(Path(self.envs_directory).parent)
Expand Down Expand Up @@ -76,7 +78,7 @@ def validate(self):
return False
return True
except Exception as error:
logger.error(error.stderr)
logger.info(error.stderr)

return False

Expand Down Expand Up @@ -149,7 +151,13 @@ def install_backend_executable(self):
pass

def create_environment(self, packages=None, channels=None, force=False):
command = [self.external_executable, "create", "-p", self.environment_path]
command = [
self.external_executable,
"create",
"-p",
self.environment_path,
f"python={self.python_version}" if self.python_version else "python",
]

packages = [] if packages is None else packages
if packages:
Expand Down Expand Up @@ -214,7 +222,7 @@ def export_environment(self, export_file_path=None):
logger.info(result.stdout)
return BackendActionResult(status=True, output=result.stdout)
except subprocess.CalledProcessError as error:
logger.error(error.stderr)
logger.info(error.stderr)
return BackendActionResult(status=False, output=error.stderr)
except Exception as error:
return BackendActionResult(status=False, output=str(error))
Expand Down Expand Up @@ -246,7 +254,7 @@ def import_environment(self, import_file_path, force=False):
logger.info(result.stdout)
return BackendActionResult(status=True, output=result.stdout)
except subprocess.CalledProcessError as error:
logger.error(error.stderr)
logger.info(error.stderr)
return BackendActionResult(
status=False,
output=(
Expand Down Expand Up @@ -287,7 +295,7 @@ def install_packages(
status=True, output=result.stdout or result.stderr
)
except subprocess.CalledProcessError as error:
logger.error(error.stderr)
logger.info(error.stderr)
return BackendActionResult(status=False, output=error.stderr)
except Exception as error:
return BackendActionResult(status=False, output=str(error))
Expand All @@ -311,7 +319,7 @@ def uninstall_packages(self, packages, force=False, capture_output=False):
except subprocess.CalledProcessError as error:
if "PackagesNotFoundError" in error.stderr:
return BackendActionResult(status=True, output=error.stderr)
logger.error(error.stderr)
logger.info(error.stderr)
return BackendActionResult(status=False, output=error.stderr)
except Exception as error:
return BackendActionResult(status=False, output=str(error))
Expand All @@ -336,7 +344,7 @@ def update_packages(self, packages, force=False, capture_output=False):
else:
return BackendActionResult(status=True, output=result.stdout)
except subprocess.CalledProcessError as error:
logger.error(error.stderr)
logger.info(error.stderr)
return BackendActionResult(status=False, output=error.stderr)
except Exception as error:
return BackendActionResult(status=False, output=str(error))
Expand Down Expand Up @@ -420,7 +428,7 @@ def list_environments(self):

return BackendActionResult(status=True, output=environments)
except subprocess.CalledProcessError as error:
logger.error(error.stderr)
logger.info(error.stderr)
return BackendActionResult(status=False, output=error.stderr)
except Exception as error:
return BackendActionResult(status=False, output=str(error))
Loading
Loading