PR: Changes for handling/customizing shortcuts via traitlet variables and a coverage upload fix#621
PR: Changes for handling/customizing shortcuts via traitlet variables and a coverage upload fix#621jsbautista wants to merge 62 commits intospyder-ide:mainfrom
Conversation
jsbautista
changed the title
dalthviz
left a comment
dalthviz
left a comment
There was a problem hiding this comment.
Thank @jsbautista for your work here! Added some suggestions that should prevent the changes here to cause a segfault. If you have any question about the suggested changes let me know!
Co-authored-by: Daniel Althviz Moré <16781833+dalthviz@users.noreply.github.com>
dalthviz
left a comment
dalthviz
left a comment
There was a problem hiding this comment.
Thanks for the latest changes @jsbautista ! Left some new comments/suggestions related with the method that gathers the different actions with shortcuts over a dictionary. Also, it could be nice to add a GIF or a command/flag/config file over the PR description to show an example of how changing the shortcuts could be done using the work being done here.
|
Note: Merging this should be done via a squash merge (there are quite a number of commits with duplicated/not very informative messages) |
dalthviz
changed the title
dalthviz
changed the title
|
Note: Adding this as part of the 5.7.0 release but depending on reviews/feedback probably could be moved to another future minor/major release (5.8.0 or 6.0.0) |
3 participants
Preview:
