Skip to content

Comments

PR: Make the plugin work with Spyder prereleases, fix tests and simplify setup on CI#23

Merged
ccordoba12 merged 6 commits intospyder-ide:mainfrom
ccordoba12:fix-spyder-prereleases
May 15, 2025
Merged

PR: Make the plugin work with Spyder prereleases, fix tests and simplify setup on CI#23
ccordoba12 merged 6 commits intospyder-ide:mainfrom
ccordoba12:fix-spyder-prereleases

Conversation

@ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented May 14, 2025

  • Our tests were failing because the plugin couldn't install Spyder-kernels 3.1.0a1, which is now the minimal version required by Spyder 6.1.0a2.
  • To fix that, I added the Spyder-kernels prerelease channels to the conda-forge one if we detect Spyder's version is a prerelease.
  • Switch to micromamba instead of conda on CI (for some odd reason conda 25 can't resolve the prerelease conda-forge channels).
  • Simplify setup on CI by using env yaml files for micromamba and adding an extra_requires/test entry for pip.
  • Add codecov.yml to configure codecov and avoid a failure on PRs due to coverage.
  • Depends on PR: Fix passing multiple channels when creating envs/installing packages with the Conda-like backend envs-manager#31.

- For that we need to add the conda-forge prerelease channels of
Spyder-kernels.
- This is also necessary to make our test pass.
 --branch=fix-channels --update --force external-deps/envs-manager

subrepo:
  subdir:   "external-deps/envs-manager"
  merged:   "633d1dd"
upstream:
  origin:   "https://github.com/ccordoba12/envs-manager.git"
  branch:   "fix-channels"
  commit:   "633d1dd"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "ea10886"
@ccordoba12 ccordoba12 added this to the v0.1.0 milestone May 14, 2025
@ccordoba12 ccordoba12 self-assigned this May 14, 2025
@ccordoba12 ccordoba12 added the bug Something isn't working label May 14, 2025
@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

❌ Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.60%. Comparing base (e0f38c1) to head (c63a6a1).
⚠️ Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
spyder_env_manager/spyder/widgets/main_widget.py 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   76.53%   76.60%   +0.07%     
==========================================
  Files          11       11              
  Lines         963      966       +3     
==========================================
+ Hits          737      740       +3     
  Misses        226      226              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ccordoba12 ccordoba12 force-pushed the fix-spyder-prereleases branch 4 times, most recently from 22b906e to b18a0cd Compare May 15, 2025 04:32
- Conda 25 fails to resolve the conda-forge prerelease channels for some
odd reason.
- Add an extra_require/test entry to setup.py. That allows to test that
that file is working as expected.
- Use env yml files for micromamba to easily declare conda-forge
prerelease channels.
@ccordoba12 ccordoba12 force-pushed the fix-spyder-prereleases branch from b18a0cd to 78435f7 Compare May 15, 2025 15:47
@ccordoba12 ccordoba12 changed the title PR: Make the plugin work with Spyder prereleases PR: Make the plugin work with Spyder prereleases and fix tests May 15, 2025
@ccordoba12 ccordoba12 force-pushed the fix-spyder-prereleases branch from 78435f7 to 11e8944 Compare May 15, 2025 16:02
@ccordoba12 ccordoba12 changed the title PR: Make the plugin work with Spyder prereleases and fix tests PR: Make the plugin work with Spyder prereleases, fix tests and simplify setup on CI May 15, 2025
…manager.git --branch=main --update --force external-deps/envs-manager

subrepo:
  subdir:   "external-deps/envs-manager"
  merged:   "b5df9bc"
upstream:
  origin:   "https://github.com/spyder-ide/envs-manager.git"
  branch:   "main"
  commit:   "b5df9bc"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "ea10886"
@ccordoba12 ccordoba12 merged commit 54dce17 into spyder-ide:main May 15, 2025
8 checks passed
@ccordoba12 ccordoba12 deleted the fix-spyder-prereleases branch May 15, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant