PR: Use Spyder prefs to set light/dark notebook theme#419
Merged
jitseniesen merged 3 commits intospyder-ide:masterfrom May 5, 2023
Merged
PR: Use Spyder prefs to set light/dark notebook theme#419jitseniesen merged 3 commits intospyder-ide:masterfrom
jitseniesen merged 3 commits intospyder-ide:masterfrom
Conversation
The function is called .get_name() in the plugin and .get_title() in the widget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some functionality that was left out of the big PR #396: the Spyder prefs has a Notebook pane in which the user can choose to use the light or dark theme, but the notebook did not actually follow this setting.
The PR also fixes my typo in PR #417.
Fixes #402.