PR: Pass connection file when opening console#422
Merged
jitseniesen merged 2 commits intospyder-ide:masterfrom Jun 25, 2023
Merged
PR: Pass connection file when opening console#422jitseniesen merged 2 commits intospyder-ide:masterfrom
jitseniesen merged 2 commits intospyder-ide:masterfrom
Conversation
ccordoba12
approved these changes
May 8, 2023
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @jitseniesen!
Before, we passed the kernel ID when calling `create_client_for_kernel()` in the IPython Console plugin. This worked, even though that function expected the connection file, because that function used `find_connection_file()` to fix the path to the connection file. After the refactor in PR spyder-ide/spyder#19062, the argument passed for the connection file is expected to be really the file path and no attempt to fix it is made, so now we have to really pass the connection file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, we passed the kernel ID when calling
create_client_for_kernel()in the IPython Console plugin. This worked, even though that function expected the connection file, because that function usedfind_connection_file()to fix the path to the connection file. After the refactor in PR spyder-ide/spyder#19062, the argument passed for the connection file is expected to be really the file path and no attempt to fix it is made, so now we have to really pass the connection file.Fixes #421.
Here is a GIF of the console in action: