Fix interrupting Spyder kernel#482
Merged
jitseniesen merged 4 commits intospyder-ide:masterfrom Mar 29, 2025
Merged
Conversation
Specify sensible default values for Spyder in the Python code for the notebook server, so that fewer arguments need to be specified on the command line when starting the server. The --password command line argument is removed because it does not seem to do anything.
Interrupting a kernel is done on Unix by sending SIGINT to the Python process. However, Spyder kernels use `conda run` to run the kernel in the correct environment. The SIGINT signal should not be sent to the `conda run` process, because that causes it to quit. Instead, find the Python process started by `conda run`, because it will handle SIGINT correctly by raising a KeyboardInterrupt.
The fix in the previous commit should only be applied if the notebook kernel was started with `conda run`, in which case the PID in the info file identifies the conda process. Otherwise, the PID identifies the kernel process, as normal for Jupyter kernel, and the normal implementation for interrupting should be followed.
This does not really add a dependency because psutil is used in Spyder so it is already an indirect dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interrupting a kernel is done on Unix by sending SIGINT to the Python process. However, Spyder kernels use
conda runto run the kernel in the correct environment. The SIGINT signal should not be sent to theconda runprocess, because that causes it to quit. Instead, find the Python process started byconda run, because it will handle SIGINT correctly by raising a KeyboardInterrupt.This PR does some further clean up in the code for the notebook server because I now understand how to specify default configuration values instead of passing them on the command line.
Fixes #478