Skip to content

PR: Run CI tests against Python 3.12 #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jitseniesen merged 2 commits into from
Aug 16, 2025
Merged

PR: Run CI tests against Python 3.12 #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5100634
CI: Test Python 3.12 (instead of Python 3.10)
jitseniesen Aug 11, 2025
4daf721
Fix test_shutdown_all_servers
jitseniesen Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
fail-fast: false
matrix:
OS: ['ubuntu', 'macos', 'windows']
PYTHON_VERSION: ['3.9', '3.10', '3.11']
PYTHON_VERSION: ['3.9', '3.11', '3.12']
SPYDER_SOURCE: ['conda', 'git']
name: ${{ matrix.OS }} py${{ matrix.PYTHON_VERSION }} spyder-from-${{ matrix.SPYDER_SOURCE }}
runs-on: ${{ matrix.OS }}-latest
Expand Down
3 changes: 2 additions & 1 deletion spyder_notebook/utils/tests/test_servermanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
# Standard library imports
import datetime
import os.path as osp
from unittest.mock import ANY

# Third party imports
import pytest
Expand Down Expand Up @@ -207,7 +208,7 @@ def test_shutdown_all_servers(mocker):

serverManager.shutdown_all_servers()

assert mock_shutdown.called_once_with(server1.server_info)
mock_shutdown.assert_called_once_with(server1.server_info, log=ANY)
assert server1.state == ServerState.FINISHED
assert server2.state == ServerState.ERROR

Expand Down
Loading