PR: Refactor Remote Client kernel management#23720
Merged
ccordoba12 merged 23 commits intospyder-ide:masterfrom Mar 22, 2025
Merged
PR: Refactor Remote Client kernel management#23720ccordoba12 merged 23 commits intospyder-ide:masterfrom
ccordoba12 merged 23 commits intospyder-ide:masterfrom
Conversation
336fc59 to
6a58753
Compare
Also, add missing copyright header to new files that didn't have it.
ccordoba12
reviewed
Mar 21, 2025
Member
ccordoba12
left a comment
There was a problem hiding this comment.
Great work here @hlouzada! Just some small questions and a couple of suggested fixes for you.
| dict[str, type[SpyderBaseJupyterAPIType]] | ||
| ] = {} | ||
| ] = { | ||
| JupyterAPI.__qualname__: JupyterAPI, |
Member
There was a problem hiding this comment.
I haven't seen this before. What's __qualname__ used for?
Contributor
Author
There was a problem hiding this comment.
It's used to get the fully qualified name from the python object. I'm using it in case someone might define another API with the same name. This way there's no overwrites when using the register_api decorator
52524c6 to
fc28a64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
ipythonconsole.ipythonconsole.Refactor the
remoteclientplugin's remote kernel logic so the kernels magnamentare done in
ipythonconsoleplugin using the base Jupyter's API with the new modules system.Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @hlouzada