PR: Return an iterable from ls method of SpyderRemoteFileServicesAPI (Remote client)#24014
Merged
ccordoba12 merged 7 commits intospyder-ide:masterfrom Mar 25, 2025
Merged
Conversation
hlouzada
changed the title
ls method of SpyderRemoteFileServicesAPI
ccordoba12
changed the title
ls method of SpyderRemoteFileServicesAPIls method of SpyderRemoteFileServicesAPI (Remote client)
…deps/spyder-remote-services subrepo: subdir: "external-deps/spyder-remote-services" merged: "fc7095d76" upstream: origin: "https://github.com/spyder-ide/spyder-remote-services" branch: "feat-straming-ls" commit: "fc7095d76" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "cce3d93"
…/spyder-remote-services subrepo: subdir: "external-deps/spyder-remote-services" merged: "b4de4a021" upstream: origin: "https://github.com/spyder-ide/spyder-remote-services" branch: "main" commit: "b4de4a021" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "cce3d93"
hlouzada
force-pushed
the
feat-remote-files-ls-generator
branch
from
dd22a6f to
ed02b61
Compare
ccordoba12
reviewed
Mar 23, 2025
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Two small style suggestions for @hlouzada, the rest looks good to me.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Modified
lsmethod fromSpyderRemoteFileServicesAPIto return an async generator and consume fron the stream of ls generated from thespyder-remote-services.Implements the client-side update for: spyder-ide/spyder-remote-services#12
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @hlouzada