PR: Remove install scripts because they're no longer needed (Update manager)#24243
Closed
ccordoba12 wants to merge 1 commit intospyder-ide:masterfrom
Closed
PR: Remove install scripts because they're no longer needed (Update manager)#24243ccordoba12 wants to merge 1 commit intospyder-ide:masterfrom
ccordoba12 wants to merge 1 commit intospyder-ide:masterfrom
Conversation
Contributor
|
@ccordoba12, these scripts are still used to install major updates, i.e. downloading and launching the package installers. However, much of the scripts can be trimmed out. This is also the case for the (identical) scripts in the Spyder-updater. It was my plan to clean these up further in another PR. I would recommend closing this PR. |
Contributor
|
spyder/spyder/plugins/updatemanager/widgets/update.py Lines 476 to 481 in 2193e4d |
Member
Author
Ok, I wasn't aware of that.
Ok, closing then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
spyder-updaterto handle updates (Installers) #24144.Issue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12