Skip to content

Comments

PR: Remove install scripts because they're no longer needed (Update manager)#24243

Closed
ccordoba12 wants to merge 1 commit intospyder-ide:masterfrom
ccordoba12:followup-of-pr-24144
Closed

PR: Remove install scripts because they're no longer needed (Update manager)#24243
ccordoba12 wants to merge 1 commit intospyder-ide:masterfrom
ccordoba12:followup-of-pr-24144

Conversation

@ccordoba12
Copy link
Member

Description of Changes

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@mrclary
Copy link
Contributor

mrclary commented Apr 18, 2025

@ccordoba12, these scripts are still used to install major updates, i.e. downloading and launching the package installers.

However, much of the scripts can be trimmed out. This is also the case for the (identical) scripts in the Spyder-updater. It was my plan to clean these up further in another PR.

I would recommend closing this PR.

@mrclary
Copy link
Contributor

mrclary commented Apr 18, 2025

def _start_major_install(self):
"""Install major update from downloaded installer"""
# Install script
# Copy to temp location to be safe
script_name = 'install.' + ('bat' if os.name == 'nt' else 'sh')
script_path = osp.abspath(__file__ + '/../../scripts/' + script_name)

@ccordoba12
Copy link
Member Author

these scripts are still used to install major updates, i.e. downloading and launching the package installers.

Ok, I wasn't aware of that.

I would recommend closing this PR.

Ok, closing then.

@ccordoba12 ccordoba12 closed this Apr 18, 2025
@ccordoba12 ccordoba12 removed this from the v6.1.0a2 milestone Apr 18, 2025
@ccordoba12 ccordoba12 deleted the followup-of-pr-24144 branch April 18, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants