PR: Remove CONF usage in MouseShortcutEditor (Editor)#24250
Merged
ccordoba12 merged 1 commit intospyder-ide:masterfrom Apr 20, 2025
Merged
PR: Remove CONF usage in MouseShortcutEditor (Editor)#24250ccordoba12 merged 1 commit intospyder-ide:masterfrom
CONF usage in MouseShortcutEditor (Editor)#24250ccordoba12 merged 1 commit intospyder-ide:masterfrom
Conversation
Contributor
|
@ccordoba12 Just looking this over, it looks like I initially also used def apply_mouse_shortcuts(self):
"""Set new config to CONF"""
self.editor_config_page.set_option(
'mouse_shortcuts', self.mouse_shortcuts
) |
Member
Author
Yeah, that's right! Thanks for checking @athompson673. That code should be instead: def apply_mouse_shortcuts(self):
"""Set new config to CONF"""
self.set_conf('mouse_shortcuts', self.mouse_shortcuts)Could you open another PR for it? |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
I missed this in my review of PR #23463.
Issue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12