Fix isAscii returning true for malformed surrogates#9261
Open
one-kash wants to merge 1 commit intosquare:masterfrom
Open
Fix isAscii returning true for malformed surrogates#9261one-kash wants to merge 1 commit intosquare:masterfrom
one-kash wants to merge 1 commit intosquare:masterfrom
Conversation
The previous implementation used `length == utf8Size()` to determine if a string was ASCII. This was incorrect because Okio's utf8Size() maps malformed surrogates (unpaired high/low surrogates) to the replacement character `?` which is 1 byte in UTF-8. This caused strings like "\uD800.com" (unpaired high surrogate) to incorrectly report as ASCII since: - length = 5 (one char for surrogate + 4 for ".com") - utf8Size() = 5 (surrogate mapped to '?' = 1 byte + 4 for ".com") The fix iterates through each character and checks if its code point is within the ASCII range (0-127). Fixes square#6357
yschimke
reviewed
Jan 25, 2026
|
|
||
| /** Returns true if the [String] is ASCII encoded (0-127). */ | ||
| private fun String.isAscii() = length == utf8Size().toInt() | ||
| private fun String.isAscii() = all { it.code <= 127 } |
Collaborator
There was a problem hiding this comment.
I suspect we want to avoid Iterable.all to avoid an allocation.
yschimke
reviewed
Jan 25, 2026
Comment on lines
+821
to
+827
| // Unpaired high surrogate - should not match any hostname | ||
| assertThat(verifier.verify("\uD800.com", session)).isFalse() | ||
| assertThat(verifier.verify("foo\uD800.com", session)).isFalse() | ||
|
|
||
| // Unpaired low surrogate - should not match any hostname | ||
| assertThat(verifier.verify("\uDC00.com", session)).isFalse() | ||
| assertThat(verifier.verify("foo\uDC00.com", session)).isFalse() |
Collaborator
There was a problem hiding this comment.
Would any of these have matched before the change? is there some case where length == utf8Size().toInt() would match because of offsetting issues, longer lower case, and malformed surrogate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
isAscii()extension function inOkHostnameVerifierusedlength == utf8Size()to determine if a string was ASCII. This was incorrect because Okio'sutf8Size()maps malformed surrogates (unpaired high/low surrogates) to the replacement character?which is 1 byte in UTF-8.This caused strings like
"\uD800.com"(unpaired high surrogate) to incorrectly report as ASCII since:length = 5(one char for surrogate + 4 for ".com")utf8Size() = 5(surrogate mapped to '?' = 1 byte + 4 for ".com")The fix replaces the comparison with a simple character iteration check:
all { it.code <= 127 }Changes
isAscii()to iterate through characters and check code pointsTest Plan
malformedSurrogatesAreNotAsciitest that verifies unpaired high/low surrogates are rejectedHostnameVerifierTesttests continue to passFixes #6357