Restore Security::ErrorDetail::detailEntry initialization#2364
Open
somecookie wants to merge 10 commits intosquid-cache:masterfrom
Open
Restore Security::ErrorDetail::detailEntry initialization#2364somecookie wants to merge 10 commits intosquid-cache:masterfrom
somecookie wants to merge 10 commits intosquid-cache:masterfrom
Conversation
rousskov
approved these changes
Jan 30, 2026
Contributor
rousskov
left a comment
rousskov
left a comment
There was a problem hiding this comment.
Thank you for fixing this regression.
rousskov
added
M-cleared-for-merge
squid-anubis
pushed a commit
that referenced
this pull request
Feb 1, 2026
2023 commit 4e14397 accidentally removed code that was setting `detailEntry` data member, breaking `%ssl_error_descr` expansion: `Security::ErrorDetail::printErrorDescription()` would always print `[Not available]`. Squid still printed non-configurable request-independent error code _name_ correctly because the corresponding `printErrorCode()` method only uses `detailEntry` as a performance optimization. The effects of this fix are visible, for example, in generated ERR_SECURE_CONNECT_FAIL error responses: ```diff - <p>[Not available]: /CN=...</p> + <p>Certificate does not match domainname: /CN=...</p> ``` This is a Measurement Factory project.
squid-anubis
added
M-waiting-staging-checks
rousskov
removed
the
S-could-use-an-approval
Contributor
@kinkie, would you mind checking our |
rousskov
added
the
S-waiting-for-QA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2023 commit 4e14397 accidentally removed code that was setting
detailEntrydata member, breaking%ssl_error_descrexpansion:Security::ErrorDetail::printErrorDescription()would always print[Not available].Squid still printed non-configurable request-independent error code
name correctly because the corresponding
printErrorCode()methodonly uses
detailEntryas a performance optimization.The effects of this fix are visible, for example, in generated
ERR_SECURE_CONNECT_FAIL error responses:
This is a Measurement Factory project.