Terminate active Runners on FATAL shutdown #2366
Conversation
rousskov
added
the
S-waiting-for-reviewer
|
|
||
| storeDirWriteCleanLogs(0); | ||
|
|
||
| RunRegisteredHere(RegisteredRunner::finishShutdown); |
There was a problem hiding this comment.
Prior to being eliminated completely, fatal() and friends should eventually become an equivalent of "abort() without dumping core"1 -- an "immediate" and safe death with minimal reporting. This change moves Squid deeper into the opposite direction. No rationale has been provided to justify making things worse.
Footnotes
-
Calls like
std::terminate,std::exit(), andstd::_Exit()should be evaluated to find the best match. ↩
There was a problem hiding this comment.
There are certain system resources (eg listening ports, logs) which still should be released even when an abort() is happening. The criteria for finishShutdown runner fits well with the abort() situation.
There was a problem hiding this comment.
The OS will take care of basic resources. No internal action is safe when "an abort() is happening". Nothing should be released by Squid itself when abort() is happening.
rousskov
removed
the
S-waiting-for-reviewer
|
|
||
| storeDirWriteCleanLogs(0); | ||
|
|
||
| RunRegisteredHere(RegisteredRunner::finishShutdown); |
There was a problem hiding this comment.
The OS will take care of basic resources. No internal action is safe when "an abort() is happening". Nothing should be released by Squid itself when abort() is happening.
2 participants
No description provided.